Skip to content

Conversation

@daniellevass
Copy link
Contributor

Description of the pull request

Lazy Sodium was causing crashes on Android because it included jna which didn't have the right interpreters. This would have been kinda complicated to include the right ones depending on how people were using the channels java client so we've gone with another solution.

@daniellevass daniellevass self-assigned this Jul 8, 2020
@daniellevass daniellevass requested a review from elverkilde July 8, 2020 13:26
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #271 into master will decrease coverage by 20.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #271       +/-   ##
=============================================
- Coverage     65.92%   45.43%   -20.50%     
- Complexity      261      284       +23     
=============================================
  Files            31       31               
  Lines          1130     3053     +1923     
  Branches         95      254      +159     
=============================================
+ Hits            745     1387      +642     
- Misses          339     1610     +1271     
- Partials         46       56       +10     
Impacted Files Coverage Δ Complexity Δ
...a/com/pusher/client/crypto/nacl/TweetNaclFast.java 33.50% <ø> (ø) 26.00 <0.00> (?)
...com/pusher/client/crypto/nacl/SecretBoxOpener.java 76.47% <100.00%> (ø) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15cdaa4...159b09f. Read the comment docs.

@daniellevass daniellevass merged commit 2d93de4 into master Jul 8, 2020
@daniellevass daniellevass deleted the dev-fix-lazysodium-5 branch July 8, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants