Fix test for _fit_sandia_cocontent #2615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echedey-ls
approved these changes
Dec 8, 2025
Contributor
echedey-ls
left a comment
echedey-ls
left a comment
There was a problem hiding this comment.
Just a whatsnew suggestion down below. LGTM as far as I've read through the issue.
Comment on lines
20
to
21
| * Corrected argument and value order in :py:func:`~pvlib.tests.ivtools.test_sde`, | ||
| in tests of :py:func:`~pvlib.ivtools.sde._fit_sandia_cocontent`. (:issue:`2613`, :pull:`2615`) |
Contributor
There was a problem hiding this comment.
I'd move this to the Testing section. This change does not improve the experience for users.
echedey-ls
reviewed
Dec 8, 2025
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
kandersolar
approved these changes
Dec 9, 2025
Member
|
Thanks @vfilter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_sde.py#2613[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.