feat: Refactor screen compatibility to <supports-screens>#69
Merged
Conversation
This commit refactors how our application declares its supported screen sizes within the Android Manifest. We are moving away from the less flexible and more error-prone <compatible-screens> tag to the recommended <supports-screens> element. **Key changes:** - Removed existing <compatible-screens> entries. - Added a <supports-screens> tag within the <application> block. **Configuration for Phone-Only Targeting:** - `android:smallScreens="true"`: Enables support for small phone screens. - `android:normalScreens="true"`: Enables support for typical smartphone screens. - `android:largeScreens="false"`: Explicitly filters out 7-inch tablet-sized devices from Play Store distribution. - `android:xlargeScreens="false"`: Explicitly filters out 10-inch+ tablet-sized devices from Play Store distribution. - `android:anyDensity="true"` and `android:resizeable="true"` are maintained for broader density support and general responsiveness. **Rationale:** This change provides a clearer and more maintainable way to communicate our app's intended device compatibility to the Google Play Store. It simplifies future updates, as extending support to tablets will only require changing a few boolean flags rather than exhaustively listing screen configurations. This also aligns our project with current Android development best practices for screen management.
irhsm
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors how our application declares its supported screen sizes within the Android Manifest. We are moving away from the less flexible and more error-prone tag to the recommended element.
Key changes:
Configuration for Phone-Only Targeting:
android:smallScreens="true": Enables support for small phone screens.android:normalScreens="true": Enables support for typical smartphone screens.android:largeScreens="false": Explicitly filters out 7-inch tablet-sized devices from Play Store distribution.android:xlargeScreens="false": Explicitly filters out 10-inch+ tablet-sized devices from Play Store distribution.android:anyDensity="true"andandroid:resizeable="true"are maintained for broader density support and general responsiveness.Rationale:
This change provides a clearer and more maintainable way to communicate our app's intended device compatibility to the Google Play Store. It simplifies future updates, as extending support to tablets will only require changing a few boolean flags rather than exhaustively listing screen configurations. This also aligns our project with current Android development best practices for screen management.