Fix the 'ParseAll' - #747
Merged
Merged
Conversation
The 'parseString' / 'parseAll' / 'resetCache' deprecation messages that flood plotting output (e.g. during strainmap.get_strain) come from matplotlib's mathtext, not py4DSTEM: matplotlib < 3.11 calls pyparsing's deprecated camelCase API once per rendered label, and pyparsing >= 3.3 displays those warnings by default. matplotlib 3.11 switched to the snake_case API, fixing the arguments at the source. Require matplotlib >= 3.11 where python allows it (3.11 needs python 3.11+; older pythons keep the previous floor), and drop the warnings filter added earlier - notebook environments manipulate warning filters per cell, so filtering was unreliable, and upgrading matplotlib removes the deprecated calls instead of hiding them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
smribet
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.