Skip to content

fix: Table.data support for negative indices#736

Open
Antyos wants to merge 7 commits into
pyapp-kit:mainfrom
Antyos:antyos/fix-table-data-negative-indices
Open

fix: Table.data support for negative indices#736
Antyos wants to merge 7 commits into
pyapp-kit:mainfrom
Antyos:antyos/fix-table-data-negative-indices

Conversation

@Antyos

@Antyos Antyos commented Jul 24, 2026

Copy link
Copy Markdown

Qt native Table _mgui_get_cell() and _mgui_set_cell() now support negative indices and will raise an IndexError if invalid indices are specified.

Previously, getting or setting to an invalid index would do nothing. Raising an IndexError is probably more useful, but may break some existing code.

Fixes #735.

@Antyos Antyos changed the title fix: Antyos/fix table data negative indices fix: Table.data support for negative indices Jul 24, 2026
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.32%. Comparing base (2d985e7) to head (e070273).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
+ Coverage   89.27%   89.32%   +0.05%     
==========================================
  Files          40       40              
  Lines        4821     4835      +14     
==========================================
+ Hits         4304     4319      +15     
+ Misses        517      516       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table data get item doesn't work with negative indices

1 participant