Fix OS X aligned new for older MACOSX targets #2038
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't think this is needed on master anymore, due to 759221f? ... however, it would be good to have a new pybind11 release that included that fix. |
Member
|
Closing, pybind 2.5 was released in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like Clang can compile the aligned new and delete, but then issues an error if compiling with OS X targets aiming at anything below OS X 10.12 (I assume the standard library of these older targets doesn't ship with the necessary functions).
It says:
error: call to unavailable function 'operator delete': introduced in macOS 10.12E.g. in this build log: https://travis-ci.com/wolfv/pygal/jobs/268938454
This happened to me on conda when compiling with
-std=c++17enabled (as conda-forge seems to target an OS X version of 10.9 or 10.8 at the moment).This is the LLVM PR https://reviews.llvm.org/D34556