feat: report clang diagnostics and fail on errors - #66
Open
henryiii wants to merge 1 commit into
Open
Conversation
A header that fails to include a file used to parse "successfully" with an incomplete AST, producing missing or empty docstrings. Diagnostics are now printed to stderr, and an error diagnostic aborts the run so no output file is written. Assisted-by: ClaudeCode:claude-fable-5
henryiii
marked this pull request as draft
August 6, 2026 18:18
henryiii
marked this pull request as ready for review
August 7, 2026 03:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Addresses finding 9 in #59.
Clang diagnostics were never reported. A header with a missing include parsed "successfully" with an incomplete AST, which silently gave missing or empty docstrings.
After the parse,
_extract_filenow prints all diagnostics to stderr and raises if any diagnostic has severity Error or higher. The exception propagates through theThreadPoolExecutoras in #60, so the process exits nonzero and no output file is written. libclang no longer prints the diagnostics itself, to prevent duplicates.Added a CLI test with a header that includes a missing file.