Merged
Conversation
Collaborator
Author
|
This was fun! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Difficulty level (1-10): [3]
Estimated time spent (hours): [2]
Completed (yes/no): [Yes]
I stretched my coding skills (if yes what did you learn?): [Nice challenge! I scraped Talk Python's RSS feed (requests/ feedparser) getting the transcripts from GH, saved all this in a sqlite3 DB, also wrote a function to generate an HTML for consumption on my Kindle (after Save-to-PDF on Mac). Some details:
decode("utf-8")to work around some transcripts being stored asbytes(required some debugging),f'{episode_id:0>3}'as alternative forzfill, cur.executemany is awesome as it works flawlessly with a generator of namedtuples, to get row dicts from sqlite useconn.row_factory = sqlite3.Row, I also usedwritelinesfor the first time!]Other feedback (what can we improve?): []