PCC30 #772
Merged
PCC30 #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmayd
requested changes
Oct 3, 2020
Collaborator
pmayd
left a comment
pmayd
left a comment
There was a problem hiding this comment.
You have pushed two different challenges, 30 and 42, please one PR per challenge
| 'CALL AN EXORCIST') | ||
|
|
||
|
|
||
| def intro_message(): |
Collaborator
There was a problem hiding this comment.
I like he use of a function for the inro text!
| input('\nGive the wheel a spin! (Hit Enter)') | ||
| print('Spinning...') | ||
| time.sleep(2) | ||
| print('\n' + STEPS_LIST[random.randint(0, len(STEPS_LIST) -1)]) |
Collaborator
There was a problem hiding this comment.
Try out random.choice! https://docs.python.org/3/library/random.html much cleaner
Collaborator
|
I am still seeing two different files in two different directories so please decide for one challenge and only commit the files for that particular challenge |
please submit this one in a new PR
Collaborator
|
@satyamasthanaa please open a new PR for challenge #42 |
Contributor
Author
|
@bbelderbos Sir, I had already made pull request #42 and it has got merged with the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATTENTION: before clicking "Create Pull Request" please submit some metadata, thanks!
Difficulty level (1-10): [7]
Estimated time spent (hours): [1]
Completed (yes/no): [yes]