PCC02 LaneHesser #784
Merged
PCC02 LaneHesser #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 14, 2020 21:25
LaneHesser
commented
Dec 15, 2020
Author
LaneHesser
left a comment
LaneHesser
left a comment
There was a problem hiding this comment.
Realized I had left out some functionality when I pushed the first time, so I made the changes and pushed again.
bbelderbos
approved these changes
Dec 15, 2020
Collaborator
bbelderbos
left a comment
bbelderbos
left a comment
There was a problem hiding this comment.
Great work, some feedback
| def draw_letters(): | ||
| """Returns 7 random letters from POUCH""" | ||
| return [ | ||
| random.choice(POUCH) |
Collaborator
There was a problem hiding this comment.
You can pick multiple random items at once: random.sample(POUCH, NUM_LETTERS)
|
|
||
| try: | ||
| if word not in DICTIONARY: | ||
| raise ValueError(f'{word} is not in the dictionary. Try again.') |
Collaborator
There was a problem hiding this comment.
seems you just print upon catching this ValueError so it's probably shorter to just to do this:
if DICTIONARY.get(word) is None:
print('error')
continue
| def get_user_input(draw): | ||
| """Asks the player to form a word with one or more letters from draw.""" | ||
| draw_copy = draw.copy() | ||
| print('Letters drawn:', *draw_copy) |
|
|
||
| def calc_optimal_word(draw): | ||
| """Calculates optimal word (highest value) given the letters in draw""" | ||
| permutations = _permutations(draw) |
Collaborator
There was a problem hiding this comment.
I would call this differently, it clashes with itertools.permutations
| valid_words = set( | ||
| ''.join(word).lower() | ||
| for word in permutations | ||
| if ''.join(word).lower() in DICTIONARY |
Collaborator
There was a problem hiding this comment.
wonder if you can do the lower() in _permutations to not do it twice here?
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Difficulty level (1-10): [4]
Estimated time spent (hours): [4]
Completed (yes/no): [Yes]
I stretched my coding skills (if yes what did you learn?): [I learned some useful functions from the itertools module and how to put a few of them together to generate all permutations of the items in a sequence.]
Other feedback (what can we improve?): []