Skip to content

Conversation

@thechrislee
Copy link

Difficulty level (1-10): [2]
Estimated time spent (hours): [1]
Completed (yes/no): [Yes]
I stretched my coding skills (if yes what did you learn?): [Not necessarily coding, but this is probably the most I've ever done with git besides cloning a repo. I've never really branched or worked with repos that have other contributors.
This challenge is the similar if not the same as one of the pybites challenges that I already completed. Truthfully, the hardest part is getting familiar with git. I need more practice.]
Other feedback (what can we improve?): [Rewrite the tests to use pytest...I may do that myself. Please cleanup the repo. When I switched to the community branch, I noticed a a file with the answers in the root of the 01 challenge. ]

…However, my solution here is shorter. thechrislee
Copy link
Collaborator

@bbelderbos bbelderbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

def calc_word_value(word):
"""Calculate the value of the word entered into function
using imported constant mapping LETTER_SCORES"""
total = 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use sum() built-in

@bbelderbos
Copy link
Collaborator

Rewrite the tests to use pytest...I may do that myself. Please cleanup the repo. When I switched to the community branch, I noticed a a file with the answers in the root of the 01 challenge. ]

What? We did not use pytest? Then this challenge must be really old, no wonder it's our first :)

Yeah the repo needs some cleanup, we did challenges via GitHub mostly the first year, then we moved to our platform + Bites.

@bbelderbos bbelderbos merged commit 214c6f0 into pybites:community Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants