Additions to #473

[BradyPlanden]

Description

This PR:

• Removes the try-except for BaseCost.__call__ for improved error messages.
• Adds apply_transform as an optional arg to BaseCost.__call__ for symmetry with the parameters class, as well as improved debugging / interaction.
• Moves Optimiser.cost_call logic into BaseCost.__call_ to remove duplicate logic/code
• Updates PintsOptimiser.f

Issue reference

Fixes #473

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

• Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
• Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

• New Feature: A non-breaking change that adds new functionality.
• Optimization: A code change that improves performance.
• Examples: A change to existing or additional examples.
• Bug Fix: A non-breaking change that addresses an issue.
• Documentation: Updates to documentation or new documentation for new features.
• Refactoring: Non-functional changes that improve the codebase.
• Style: Non-functional changes related to code style (formatting, naming, etc).
• Testing: Additional tests to improve coverage or confirm functionality.
• Other: (Insert description of change)

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All unit tests pass: $ nox -s tests
• The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

• Code is well-commented, especially in complex or unclear areas.
• Added tests that prove my fix is effective or that my feature works.
• Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (473-fix-transformations@83c3621). Learn more about missing BASE report.

Additional details and impacted files

@@                    Coverage Diff                     @@
##             473-fix-transformations     #488   +/-   ##
==========================================================
  Coverage                           ?   99.04%           
==========================================================
  Files                              ?       52           
  Lines                              ?     3564           
  Branches                           ?        0           
==========================================================
  Hits                               ?     3530           
  Misses                             ?       34           
  Partials                           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[martinjrobins]

looks great :) only one (rather picky) suggestion:

[martinjrobins]

I’ll wait for the tests 😊