Add x509 Test Vectors with PrivateKeyUsagePeriod extension#12749
Merged
Add x509 Test Vectors with PrivateKeyUsagePeriod extension#12749
PrivateKeyUsagePeriod extension#12749Conversation
alex
reviewed
Apr 9, 2025
docs/development/test-vectors.rst
Outdated
Comment on lines
+626
to
+633
| * ``both_dates.pem`` - A certificate containing PrivateKeyUsagePeriod with both | ||
| ``notBefore`` and ``notAfter`` fields set. | ||
| * ``both_dates.der`` - A certificate containing PrivateKeyUsagePeriod with both | ||
| ``notBefore`` and ``notAfter`` fields set. DER encoded. | ||
| * ``only_notBefore.pem`` - A certificate containing PrivateKeyUsagePeriod with | ||
| only ``notBefore`` field set. | ||
| * ``only_notAfter.pem`` - A certificate containing PrivateKeyUsagePeriod with | ||
| only ``notAfter`` field set. |
Member
There was a problem hiding this comment.
Can you give these files slightly more descriptive names -- I suggest prepending private_key_usage_period_ to each of the current names
Contributor
Author
There was a problem hiding this comment.
Updated names of these files. Made corresponding changes to test path construction in the other PR: https://github.com/pyca/cryptography/blob/3f0ebd0baee387ddda2fa6dfa8dd86984e2b9f5e/tests/x509/test_x509_ext.py#L1990C5-L1993C10
alex
reviewed
Apr 9, 2025
docs/development/test-vectors.rst
Outdated
Comment on lines
+628
to
+629
| * ``private_key_usage_period_both_dates.der`` - A certificate containing | ||
| PrivateKeyUsagePeriod with both ``notBefore`` and ``notAfter`` fields set. DER encoded. |
Member
There was a problem hiding this comment.
Oops, sorry I should have noticed before, we don't need a vector in both PEM and DER for the same thing, one format is fine.
Contributor
Author
There was a problem hiding this comment.
Removed DER encoded key
alex
reviewed
Apr 10, 2025
Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com>
Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com>
alex
approved these changes
Apr 10, 2025
Member
|
Thanks for your patience here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add vectors to test support for
PrivateKeyUsagePeriodin x509 certificates (introduced in #12738)