add HKDF.extract as a public API and deprecate HKDF._extract #13658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Should this be a method on |
reaperhulk
force-pushed
the
hkdf-extract
branch
from
2446ea8 to
670cded
Compare
reaperhulk
force-pushed
the
hkdf-extract
branch
from
670cded to
03da425
Compare
reaperhulk
force-pushed
the
hkdf-extract
branch
from
4a72ce0 to
d1538ec
Compare
alex
reviewed
Oct 14, 2025
|
|
||
| .. note:: | ||
| Extract is a component of the complete HKDF algorithm. | ||
| Unless required, users should ignore this method and just |
Member
There was a problem hiding this comment.
"Unless required" is kind of vague, I think you want "Unless needed for implementing an existing protocol" or something.
src/rust/src/backend/hmac.rs
Outdated
Comment on lines
94
to
95
| let data = self.get_mut_ctx()?.finish()?; | ||
| self.ctx = None; |
alex
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.