Skip to content

Conversation

@reaperhulk
Copy link
Contributor

cryptography is refactoring some of our HKDF internals and we realized you're using a private API. We've promoted extract to public in v47. This isn't released yet, but we'll be removing that old private name in 49.0.0 so I wanted to get a PR over to you. refs pyca/cryptography#13658

Update HKDF extraction method to use public API if available.
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.88%. Comparing base (4296eee) to head (5f96343).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/tls/crypto/hkdf.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4861      +/-   ##
==========================================
- Coverage   80.88%   80.88%   -0.01%     
==========================================
  Files         368      368              
  Lines       90335    90337       +2     
==========================================
- Hits        73069    73068       -1     
- Misses      17266    17269       +3     
Files with missing lines Coverage Δ
scapy/layers/tls/crypto/hkdf.py 98.11% <75.00%> (-1.89%) ⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@guedou guedou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@guedou guedou merged commit a4e81bc into secdev:master Oct 15, 2025
24 checks passed
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants