Update asn1 to 0.24.0#14497
Merged
Merged
Conversation
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
alex
previously approved these changes
Mar 18, 2026
Member
|
Looks like there's some coverage issues, PTAL |
Member
|
looks like it's the asn1::WriteError::InvalidSetOrdering paths that are uncovered |
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
auto-merge was automatically disabled
March 18, 2026 01:16
Head branch was pushed to by a user without write access
alex
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the version and makes the changes to support the new custom error types for the Writable traits.