Skip to content

Add a new CI job with Rust 1.83 and AWS-LC#14541

Merged
alex merged 1 commit intopyca:mainfrom
trail-of-forks:dm/aws-lc-msrv
Mar 25, 2026
Merged

Add a new CI job with Rust 1.83 and AWS-LC#14541
alex merged 1 commit intopyca:mainfrom
trail-of-forks:dm/aws-lc-msrv

Conversation

@DarkaMaul
Copy link
Copy Markdown
Contributor

Part of #14404, as we had coverage issues for AWS-LC gated methods.

echo "RUSTFLAGS=-Clink-arg=-Wl,-rpath=${OSSL_PATH}/lib -Clink-arg=-Wl,-rpath=${OSSL_PATH}/lib64" >> $GITHUB_ENV
if: matrix.PYTHON.OPENSSL
- run: cargo install bindgen-cli
- run: rustup run stable cargo install bindgen-cli
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using cargo install directly here yields to a problem because the version is too old for bindgen-cli when using Rust 1.83

(proof)

# potential future MSRV.
# noclippy due to: https://github.com/PyO3/pyo3/issues/5768
- {VERSION: "3.14", NOXSESSION: "rust-noclippy,tests", RUST: "1.83.0"}
- {VERSION: "3.14", NOXSESSION: "rust-noclippy,tests", RUST: "1.83.0", OPENSSL: {TYPE: "aws-lc", VERSION: "v1.71.0"}}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure the aws-lc bumper script will properly update this. (Set it to some old version and run:

          python3 .github/bin/bump_dependency.py \
            --name "AWS-LC" \
            --repo-url "https://github.com/aws/aws-lc" \
            --branch "main" \
            --file-path ".github/workflows/ci.yml" \
            --current-version-pattern 'TYPE: "aws-lc", VERSION: "(v[0-9\.]*)"' \
            --update-pattern 'TYPE: "aws-lc", VERSION: "{new_version}"' \
            --comment-pattern 'Latest tag of AWS-LC main branch, as of .*?\.' \
            --tag \
            --tag-pattern 'v[0-9\.]*'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script uses re.search that matches only the first occurrence (the one at line 46), but updates both because it uses re.sub which replaces all occurrences.

match = re.search(pattern, content)

new_content = re.sub(old_pattern, new_value, content)

The script will update both if the first occurrence needs to be updated. If the initial version of the file is in sync, it would be automatically handled.

So I would say the support is accidental - I can update the script to be more explicit.

New PR, or since it's going to be a ~20 lines change, that could fit into this one?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow up PR is fine

@alex alex merged commit 609bba5 into pyca:main Mar 25, 2026
67 checks passed
@DarkaMaul DarkaMaul deleted the dm/aws-lc-msrv branch March 26, 2026 08:29
DarkaMaul added a commit to trail-of-forks/cryptography that referenced this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants