Skip to content

Fix: bump_dependency now explicitely update all occurrences #14546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex merged 1 commit into from
Mar 26, 2026
Merged

Fix: bump_dependency now explicitely update all occurrences #14546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/bin/bump_dependency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ def get_remote_commit_sha(repo_url: str, branch: str) -> str:
return output.split("\t")[0]


def _version_key(tag: str) -> tuple[int, ...]:
version = tag.lstrip("v")
return tuple(map(int, version.split(".")))


def get_remote_latest_tag(repo_url: str, tag_pattern: str) -> str:
output = subprocess.check_output(
["git", "ls-remote", "--tags", repo_url], text=True
Expand All @@ -28,19 +33,15 @@ def get_remote_latest_tag(repo_url: str, tag_pattern: str) -> str:
if re.match(tag_pattern + "$", tag):
tags.append(tag)

def version_key(tag: str) -> tuple[int, ...]:
version = tag.lstrip("v")
return tuple(map(int, version.split(".")))

return sorted(tags, key=version_key)[-1]
return sorted(tags, key=_version_key)[-1]


def get_current_version_from_file(file_path: str, pattern: str) -> str:
with open(file_path) as f:
content = f.read()

match = re.search(pattern, content)
return match.group(1)
matches = re.findall(pattern, content)
return min(matches, key=_version_key)


def update_file_version(
Expand Down