Capitalize Python MLDSA class names from MlDsa to MLDSA#14596
Merged
reaperhulk merged 1 commit intomainfrom Apr 7, 2026
Merged
Capitalize Python MLDSA class names from MlDsa to MLDSA#14596reaperhulk merged 1 commit intomainfrom
reaperhulk merged 1 commit intomainfrom
Conversation
5 tasks
Member
|
rebase and also do mldsa44 |
Rename all Python-facing MLDSA class names: - MlDsa44PrivateKey -> MLDSA44PrivateKey - MlDsa44PublicKey -> MLDSA44PublicKey - MlDsa65PrivateKey -> MLDSA65PrivateKey - MlDsa65PublicKey -> MLDSA65PublicKey Add name= annotations to PyO3 pyclass definitions so Rust structs keep their original names but expose the capitalized names to Python. Update all Python interfaces, type stubs, tests, and documentation. https://claude.ai/code/session_01N13VBJmo4GbcFX86Yu4ugZ
alex
force-pushed
the
claude/capitalize-mldsa-python-ydTYH
branch
from
02be983 to
7282d22
Compare
reaperhulk
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MlDsa65PrivateKey→MLDSA65PrivateKeyandMlDsa65PublicKey→MLDSA65PublicKeyacross all Python interfaces, type stubs, tests, and documentationname=annotations to the PyO3#[pyclass]definitions so Rust structs keep their original names but expose the capitalizedMLDSA65*names to PythonMlDsaVariant→MLDSAVariant,TestMlDsa→TestMLDSA)Test plan
isinstancechecks work correctly (PyO3 classes register under the new ABC names)https://claude.ai/code/session_01N13VBJmo4GbcFX86Yu4ugZ