Encrypt directly into the output buffer in HPKE#14948
Merged
Merged
Conversation
Instead of having the AEAD encrypt into a fresh PyBytes and then copying the ciphertext into the enc || ct output buffer, write the ciphertext directly into the output buffer using the AEADs' encrypt_into, avoiding an allocation and a copy. https://claude.ai/code/session_011Eb7821FTtj3vMYwxsr4En
reaperhulk
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having the AEAD encrypt into a fresh
PyBytesand then copying the ciphertext into theenc || ctoutput buffer,Suite::encrypt_innernow allocates the final output buffer up front, copiesencinto the front, and encrypts directly into the remainder via the AEADs'encrypt_into— avoiding an allocation and a copy of the ciphertext.To support this,
AesGcm::encrypt_intoandChaCha20Poly1305::encrypt_intoare nowpub(crate).https://claude.ai/code/session_011Eb7821FTtj3vMYwxsr4En
Generated by Claude Code