Skip to content

Conversation

@toddabrams
Copy link
Contributor

@toddabrams toddabrams commented Sep 10, 2025

See corresponding PR in cryptography pyca/cryptography#13384

Since this PR depends on the corresponding one in cryptography, I anticipate needing to mark this as a Backward-incompatible change, once we know the cryptography version that includes the new change.

@reaperhulk
Copy link
Member

This will be difficult to test until a cryptography release. That said, the cryptography-main job is currently failing because pyOpenSSL unconditionally assumes the binding will be there even when cryptography is linked against an OpenSSL that does not support it (in this case, that job links against system OpenSSL 3.0.2).

@toddabrams
Copy link
Contributor Author

@reaperhulk Thanks for reviewing the cryptography PR and your comment here!

  • re: difficult to test -> I was able to work around locally by installing cryptography main branch, wasn't too bad.
  • re: unconditional assumption -> I’ve added a decorator that acts as a guard / conditional to address this using a pre-existing pattern 32d979a

After the next cryptography release, I’ll make the necessary changes so that the new version of pyOpenSSL requires that version of cryptography.

@toddabrams toddabrams marked this pull request as ready for review September 16, 2025 21:30
@toddabrams
Copy link
Contributor Author

@reaperhulk This is 98% ready, I just need to figure out how to require cryptography 46.0.0 beyond what I've done in 9a06dc8

@alex
Copy link
Member

alex commented Sep 16, 2025

Whatever the 3.14 bug is, we're also seeing it on other PRs, so it's not your fault.

@toddabrams
Copy link
Contributor Author

Ah, thanks for letting me know, I'll ignore that one for now. I only need to worry about the 3.7 issue ERROR: No matching distribution found for cryptography==46.0.0.

@reaperhulk
Copy link
Member

That issue has an easy fix: we dropped python 3.7 in cryptography 46 so we'll drop python 3.7 here when we bump the bound 😄

@toddabrams
Copy link
Contributor Author

toddabrams commented Sep 17, 2025

That issue has an easy fix: we dropped python 3.7 in cryptography 46 so we'll drop python 3.7 here when we bump the bound 😄

@reaperhulk Should we drop python 3.7 here or in a different PR? Is there something else still pending?

I added commits here just in case: cb720a2 5ef8f20

@reaperhulk
Copy link
Member

Putting it here is fine.

@toddabrams
Copy link
Contributor Author

Are there any other steps we're waiting on before this can be merged and included in a new release?

Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reaperhulk Didn't think really about the API design, but the impl looks good. If the API works for you, plz merge.

@reaperhulk reaperhulk merged commit f46314f into pyca:main Sep 23, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants