Rename package from httpcore to httpcore2 - #138
Conversation
There was a problem hiding this comment.
馃挕 Codex Review
httpx2/src/httpcore2/scripts/unasync.py
Line 86 in 883ce6f
After moving the package to httpcore2/, this still walks httpcore/_async, which no longer exists under src/httpcore2. As a result, the script stops validating/regenerating the package sync code and (in --check mode) exits non-zero because substitutions remain unused; this breaks the scripts/check step used by src/httpcore2/.github/workflows/test-suite.yml.
httpx2/src/httpcore2/scripts/check
Line 7 in 883ce6f
SOURCE_FILES still references httpcore, but the repository now contains httpcore2 in this subtree. That means scripts/check and scripts/lint no longer target the actual package code (and can fail on missing paths), which breaks the quality gate invoked by src/httpcore2/.github/workflows/test-suite.yml.
httpx2/src/httpcore2/scripts/publish
Line 3 in 883ce6f
The publish script still reads httpcore/__init__.py for the version, but that file no longer exists after the rename. In tagged CI runs, scripts/publish (called by src/httpcore2/.github/workflows/publish.yml) will fail before upload because the version grep targets a missing file.
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Renames the workspace-vendored httpcore to httpcore2, mirroring the earlier httpx -> httpx2 rename.
Changes:
src/httpcore/->src/httpcore2/, and the innerhttpcore/package ->httpcore2/.import httpcore/from httpcore/httpcore.Xreferences rewritten tohttpcore2in workspace source, tests, and httpx2 callers.src/httpcore2/pyproject.toml:name = "httpcore2", version path, sdist include, coverage include, ruff exclude.pyproject.toml:dependenciesand dev group now referencehttpcore2; workspace member + source point tosrc/httpcore2.Upstream docs/URLs/README/CHANGELOG branding left as-is (import-name-only rename).
Test plan
uv lockresolves clean (httpcoreremoved,httpcore2added).uv syncbuilds both editables.import httpcore->ModuleNotFoundError;import httpcore2works.scripts/lint,scripts/checkpass.uv run pytest-> 1417 passed, 1 skipped, 0 failed.AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.