Remove experimental forwarding module - #2358
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughForwarding functionality moved from Merge Risk: ⚪ Minimal · up to Forwarding implementation internals and declarations are relocated while stable forwarding APIs retain their behavior and signatures. No merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
remove the stubs changes
Summary
Logfireforwarding APIs without behavior changeslogfire.experimental.forwarding, rename its tests, and remove the correspondinglogfire-apistubThis is an intentional breaking change for imports from the experimental forwarding module in the next major release.
Tests
uv run pytest tests/test_forwarding.py tests/test_internal_forwarding.py tests/test_logfire_api.pyuv run ruff check logfire/_internal/forwarding.py logfire/_internal/main.py tests/test_forwarding.py tests/test_internal_forwarding.py tests/test_logfire_api.pyuv run ruff format --check logfire/_internal/forwarding.py logfire/_internal/main.py tests/test_forwarding.py tests/test_internal_forwarding.py tests/test_logfire_api.pyuv run pyright logfire/_internal/forwarding.py logfire/_internal/main.py tests/test_forwarding.py