Skip to content

Remove experimental forwarding module - #2358

Merged
alexmojaki merged 2 commits into
mainfrom
codex/relocate-forwarding
Sep 4, 2026
Merged

Remove experimental forwarding module#2358
alexmojaki merged 2 commits into
mainfrom
codex/relocate-forwarding

Conversation

@alexmojaki

Copy link
Copy Markdown
Contributor

Summary

  • relocate the forwarding response type and proxy helpers into the existing internal forwarding implementation
  • preserve the stable top-level and Logfire forwarding APIs without behavior changes
  • remove logfire.experimental.forwarding, rename its tests, and remove the corresponding logfire-api stub

This is an intentional breaking change for imports from the experimental forwarding module in the next major release.

Tests

  • uv run pytest tests/test_forwarding.py tests/test_internal_forwarding.py tests/test_logfire_api.py
  • uv run ruff check logfire/_internal/forwarding.py logfire/_internal/main.py tests/test_forwarding.py tests/test_internal_forwarding.py tests/test_logfire_api.py
  • uv run ruff format --check logfire/_internal/forwarding.py logfire/_internal/main.py tests/test_forwarding.py tests/test_internal_forwarding.py tests/test_logfire_api.py
  • uv run pyright logfire/_internal/forwarding.py logfire/_internal/main.py tests/test_forwarding.py

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 9ab85a0a-061d-4d4d-b2bc-6120f6003c67

📥 Commits

Reviewing files that changed from the base of the PR and between 1c08478 and 1c07f85.

📒 Files selected for processing (7)
  • logfire-api/logfire_api/_internal/forwarding.pyi
  • logfire-api/logfire_api/_internal/main.pyi
  • logfire-api/logfire_api/experimental/forwarding.pyi
  • logfire/_internal/forwarding.py
  • logfire/_internal/main.py
  • logfire/experimental/forwarding.py
  • tests/test_forwarding.py
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • pydantic/logfire (manual)
  • pydantic/pydantic-ai (manual)
💤 Files with no reviewable changes (2)
  • logfire-api/logfire_api/experimental/forwarding.pyi
  • logfire/experimental/forwarding.py

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

Forwarding functionality moved from logfire.experimental.forwarding to logfire._internal.forwarding. The internal module now defines the response type, export forwarding function, and Starlette proxy handler. Internal stubs and exports were updated. The experimental module declarations and implementation were removed. Integration imports and forwarding tests now use the internal module.

Merge Risk: ⚪ Minimal · up to 1c07f

Forwarding implementation internals and declarations are relocated while stable forwarding APIs retain their behavior and signatures. No merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states the primary change: removal of the experimental forwarding module.
Description check ✅ Passed The description accurately explains the relocation, API compatibility, intentional breaking change, removed module, and validation checks.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/relocate-forwarding

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@alexmojaki alexmojaki Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the stubs changes

@alexmojaki
alexmojaki added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit bd8ab36 Sep 4, 2026
26 checks passed
@alexmojaki
alexmojaki deleted the codex/relocate-forwarding branch September 4, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant