Skip to content

Remove deprecated Flask exclude_urls argument - #2360

Merged
alexmojaki merged 1 commit into
mainfrom
codex/remove-flask-exclude-urls
Sep 4, 2026
Merged

Remove deprecated Flask exclude_urls argument#2360
alexmojaki merged 1 commit into
mainfrom
codex/remove-flask-exclude-urls

Conversation

@alexmojaki

Copy link
Copy Markdown
Contributor

Summary

  • remove Logfire's deprecated exclude_urls compatibility translation
  • preserve the supported excluded_urls forwarding behavior
  • verify the removed spelling now fails as an unexpected OpenTelemetry keyword

Tests

  • uv run pytest tests/otel_integrations/test_flask.py -q
  • uv run ruff check logfire/_internal/integrations/flask.py tests/otel_integrations/test_flask.py
  • uv run pyright logfire/_internal/integrations/flask.py tests/otel_integrations/test_flask.py

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: de56c43e-1ead-458a-99da-3e34d12cf176

📥 Commits

Reviewing files that changed from the base of the PR and between 1c08478 and 82abf80.

📒 Files selected for processing (2)
  • logfire/_internal/integrations/flask.py
  • tests/otel_integrations/test_flask.py
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • pydantic/logfire (manual)
  • pydantic/pydantic-ai (manual)
💤 Files with no reviewable changes (1)
  • logfire/_internal/integrations/flask.py

Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

Flask instrumentation no longer supports the deprecated exclude_urls argument or its warning path. The supported excluded_urls argument is forwarded to FlaskInstrumentor.instrument_app. Tests verify both forwarding and TypeError rejection of exclude_urls.

Merge Risk: ⚪ Minimal · up to 82abf

Flask instrumentation now accepts only excluded_urls and rejects the removed exclude_urls keyword. The supported forwarding and deprecated-argument rejection behavior are covered, with no remaining merge-readiness risk identified.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: removal of the deprecated Flask exclude_urls argument.
Description check ✅ Passed The description directly explains the removal, preserved excluded_urls behavior, and related tests and checks.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/remove-flask-exclude-urls

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@alexmojaki
alexmojaki added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit c5b7236 Sep 4, 2026
24 checks passed
@alexmojaki
alexmojaki deleted the codex/remove-flask-exclude-urls branch September 4, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant