Remove deprecated Flask exclude_urls argument - #2360
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughFlask instrumentation no longer supports the deprecated Merge Risk: ⚪ Minimal · up to Flask instrumentation now accepts only excluded_urls and rejects the removed exclude_urls keyword. The supported forwarding and deprecated-argument rejection behavior are covered, with no remaining merge-readiness risk identified. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
exclude_urlscompatibility translationexcluded_urlsforwarding behaviorTests
uv run pytest tests/otel_integrations/test_flask.py -quv run ruff check logfire/_internal/integrations/flask.py tests/otel_integrations/test_flask.pyuv run pyright logfire/_internal/integrations/flask.py tests/otel_integrations/test_flask.py