Skip to content

fixes bug #4627 to make a copy of the attrs in the merged object - #4629

Merged
max-sixty merged 3 commits into
pydata:masterfrom
gladclef:merge-does-not-copy-attrs-4627
Dec 2, 2020
Merged

fixes bug #4627 to make a copy of the attrs in the merged object#4629
max-sixty merged 3 commits into
pydata:masterfrom
gladclef:merge-does-not-copy-attrs-4627

Conversation

@gladclef

Copy link
Copy Markdown
Contributor

@dcherian dcherian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @gladclef

I see this is your first PR here. welcome to xarray!

Comment thread doc/whats-new.rst Outdated
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
@gladclef

gladclef commented Dec 1, 2020

Copy link
Copy Markdown
Contributor Author

Thanks @dcherian! Good to be here! :)

@max-sixty

Copy link
Copy Markdown
Collaborator

Great, merging! Thanks @gladclef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

merge(combine_attrs='override') does not copy attrs but instead references attrs from the first object

3 participants