pyfa 2 font issues on linux

[Arherion]

o/

After updating to 2.0.0 fonts in fitting section and tabs became weird (all system settings are the same for both):

2.0.0

1.36

OS: Arch linux

Expected: fonts should looks like the same as for 1.36

[alexanderdarino]

Fonts are different in Windows 2.x as well

[bnrc]

Same here...

OS: Fedora27

but with wxPython i would expect grafical bugs to be cross-plattform too

[blitzmann]

Indeed, this is a thing that happened due to the upgrade to wxPython, their font rendering was tweaked a bit. TBH, I haven't had time to sit down and get anal about the font sizes since it's a relatively small problem. The fonts in pyfa as a whole could probably use some love, they've always been a bitch to deal with due to every platform using them in different ways.

A quick way of changing the size of the is through https://github.com/pyfa-org/Pyfa/blob/master/gui/utils/fonts.py - you can just make the sizes (6, 7, 8) and see how that looks and feels. :)

[blitzmann]

I've added the help wanted label to this in case anyone is interested in picking up a personal project before I get to it lol. pyfa doesn't handle font's very well, and one of the motivations of moving to wxPython 4 was to better support proper font support. Need to also understand that the OS X client renders font sizes differently. There are certain widgets (like our gauges) where the font size doesn't seem to really change, but then some things they do (like the module listing and tabs). Not sure what the difference between these two are, but something to research and possibly apply client-wide

[BoraVyvorant]

I'm also seeing changes in font size between pyfa v1 and pyfa v2 under macOS 10.13.4, but in my case it's going the other way (v2 ends up with smaller text, which is not great for my old eyes).

v1.36:

v2.0.1:

It's not the end of the world, obviously, but it would be nice to at least revert the sizes to roughly what they were before, or at best provide some control over them from the UI.

[blitzmann]

Yeah, each platform seems to treat them differently, which is why it's always been a pain in the ass. Controlling them from the UI would be the ultimate end goal, absolutely, but it is a bit of a process since all GUI elements will probably have to be touched.

[DarkFenX]

Fitting pane fonts do not respect font settings from font.py

font = wx.SystemSettings.GetFont(wx.SYS_DEFAULT_GUI_FONT)

(from fittingView.py)

I have no idea how wx handles fonts, but when I change it to wx.Font(10, wx.SWISS, wx.NORMAL, wx.BOLD) (borrowed from another panels, which follow font settings) - it produces more acceptable results:

(top row is market pane, bottom row is fitting pane - so still different, but not as much as it used to be)

[blitzmann]

That should be a quick fix, at least until more investigation can find a better solution :D

[DarkFenX]

Well, obviously it should still use fonts.py, but should have separate entry for fitting pane - just to make sure mac users are still handled separately.

[DarkFenX]

Decided to take a deeper look into differences. In fitting pane, with wx.Font(10, wx.SWISS, wx.NORMAL, wx.BOLD):

default encoding: 43 (FONTENCODING_UTF8)
face name: Sans
family: 74 (FONTFAMILY_SWISS)
native font info desc: Sans Bold 10
native font info user desc: Sans Bold 10
pixel size: (10, 17)
point size: 10
style: 90 (FONTSTYLE_NORMAL)
weight: 92 (FONTWEIGHT_BOLD)

In market item list, which is the proper font:

default encoding: 43 (FONTENCODING_UTF8)
face name: Cantarell
family: 70 (FONTFAMILY_DEFAULT)
native font info desc: Cantarell 11
native font info user desc: Cantarell 11
pixel size: (8, 20)
point size: 11
style: 90 (FONTSTYLE_NORMAL)
weight: 90 (FONTWEIGHT_NORMAL)

So, i suppose that setting some of font parameters manually is bad idea. Namely, setting swiss style sets sans, which is different face type from face type used in other widgets (cantarell). So, getting system or default font should be the way to go. I found 2 ways to do that: font = self.GetFont() and font = wx.SystemSettings.GetFont(wx.SYS_DEFAULT_GUI_FONT). The latter is used in column sizing code below, so i guess i will stick to it.

[DarkFenX]

Should be fixed in 051e601 - but i tested only on linux. Hopfully, it works under windows and mac as well. If someone can check it, please do.

There're plently of other places where system font is overridden by the way, i wonder if we want to fix them as well. Search for wx.Font( calls to find them.

[DarkFenX]

This is py2/wx3 pyfa:

At least tab headers are smaller, maybe there're more differences which are hard to spot with naked eye.

[DarkFenX]

I changed tab headers as well, switched from 10pt to 8pt. If it looks too small on Macs (too small compared to win/linux or too small compared to old version), we might want to use fonts.NORMAL size (which is defined as 11 for MacOS).

We should review how pyfa handles fonts later, currently it's a bit messy: some parts are using defines from fonts, some parts use values hardcoded in widgets. But I am unsure if it should be handled within scope of this task.