Update pyfar introduction notebook - #173
Conversation
| "The respective links are located at the top of each example notebook. \n", | ||
| "\n", | ||
| "To follow along with the workshop document, either navigate to [pyfar.org](https://pyfar.org) and scroll down to the **Workshops** section and select the **pyfar introduction**, or scan the following QR code:\n", | ||
| "For an interactive version of this notebook visit the [pyfar's example gallery](https://pyfar-gallery.readthedocs.io/en/latest/) and select the **pyfar introduction**, or scan the following QR code:\n", |
There was a problem hiding this comment.
This is not a workshop anymore, and we renamed the Wokshop section to 'Getting started'. Thought its savest to simply link to the gallery.
There was a problem hiding this comment.
maybe directly link https://pyfar-gallery.readthedocs.io/en/latest/examples_gallery.html
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "rir_inv = pf.dsp.normalize(rir_inv)\n", |
There was a problem hiding this comment.
The normalization was a little arbitrary, especially if being done before converting to minimum phase. Not doing this, also shows the effect of the filter more clearly in the plot generated below.
There was a problem hiding this comment.
This was not arbitrary. Without the normalization, the resulting filter attenuates the overall signal, i.e. it reduces the loudness of a signal passed to the filter. This usually is not wanted for equalizers, except if they also calibrate absolute level corresponding to a physical quantity.
I'd suggest to restore the normalization and explanation
| "inverter = pf.dsp.RegularizedSpectrumInversion.from_frequency_range(\n", | ||
| " rir_smoothed, frequency_range=frequency_range)\n", |
There was a problem hiding this comment.
Updated to new class to avoid a deprecation warning from pyfar
| "The respective links are located at the top of each example notebook. \n", | ||
| "\n", | ||
| "To follow along with the workshop document, either navigate to [pyfar.org](https://pyfar.org) and scroll down to the **Workshops** section and select the **pyfar introduction**, or scan the following QR code:\n", | ||
| "For an interactive version of this notebook visit the [pyfar's example gallery](https://pyfar-gallery.readthedocs.io/en/latest/) and select the **pyfar introduction**, or scan the following QR code:\n", |
There was a problem hiding this comment.
maybe directly link https://pyfar-gallery.readthedocs.io/en/latest/examples_gallery.html
335ee8f to
84bce4e
Compare
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "rir_inv = pf.dsp.normalize(rir_inv)\n", |
There was a problem hiding this comment.
This was not arbitrary. Without the normalization, the resulting filter attenuates the overall signal, i.e. it reduces the loudness of a signal passed to the filter. This usually is not wanted for equalizers, except if they also calibrate absolute level corresponding to a physical quantity.
I'd suggest to restore the normalization and explanation
|
@mberz I reintroduced the normalization in a way that I think generalizes better to other types of filters. |
3 participants
Update to avoid a pyfar depreaction warning and minor improvements.