Implement working directory option for notebook execution#172
Conversation
|
Looking at courier/54, this feature seems to work as intended. @liamhuber: with some positive reaction from you, I will merge this and make the new release. This time, I already used a release-tag formatted branch, so maybe the release will be successful on the first try. |
liamhuber
left a comment
There was a problem hiding this comment.
Yeah, super, no objections from me, just one question: it looks very similar to the existing notebooks-dir -- is there a use case where the values should differ? I.e. could we avoid changing the action file and update the build_notebooks.sh to always create CWD_ARGS from ${NOTEBOOKS_DIR} instead? I assume this would have some bad side-effect sometimes, I'm just curious to learn what it is.
One could get a similar effect by making notebooks reference resources relative to |
Summary
notebooks-working-directoryinput tobuild-notebooks.--cwdwhen set.Testing
.support/build_notebooks.shwith and without the fourth argument.actionlintto verify correct syntax and compatibility with current runners etc.Merging this PR closes #171.