Set 'notebooks' as working directory for execution and adjust paths#54
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 964 984 +20
=========================================
+ Hits 964 984 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The failing test is because the branch |
Contributor
Author
|
There was a conflicting dataset from the failed run on the used ontodocker instance which caused the notebook execution to fail. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is supposed to validate the new notebook-cwd feature introduced in pyiron/actions via this PR.
With a successful validation, this PR will also directly integrate the usage of the new feature.
The advantage afterwards is that a user cloning this repo, running jupyter and opening a notebook from
notebookscan right away execute notebooks end-to-end, even if files are referenced (like, e.g. inOntodockClient.ipynb) while also letting the CI execute them successfully. Before, there was a mismatch: CI runners had the repo root as working directory for notebook execution, a local user will typically havenotebooks/as the kernels working directory.