[Documentation] Refactor documentation#973
Conversation
📝 WalkthroughWalkthroughNotebook references are being updated across CI configuration, README navigation, and documentation table of contents. The developer notebook is updated from 4 to 5, while integration notebooks are updated from 5 to 4 versions in their respective locations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors documentation structure by renumbering/reordering notebook-based pages and updating all corresponding links and CI notebook execution steps to match.
Changes:
- Update Jupyter Book TOC entries to point to renumbered notebooks (GPAW/Quantum Espresso and Developer docs).
- Update README documentation links to match the new published doc URLs.
- Update GitHub Actions workflow to execute the renumbered notebooks in CI.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/_toc.yml | Updates the documentation table-of-contents to reference renumbered notebook pages. |
| README.md | Adjusts rendered documentation links to match the new page names/paths. |
| .github/workflows/pipeline.yml | Aligns CI papermill execution with renamed/renumbered notebooks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/pipeline.yml (1)
201-202: Parameterize pseudo_dir path to reduce CI environment coupling.The notebook hardcodes
pseudo_dir="/home/runner/work/executorlib/executorlib/tests/integration"(line 58), which only works in the GitHub Actions runner environment. Parameterize this path by: (1) adding a parameters cell to the notebook withpseudo_dir = Noneas a default, and (2) updating the workflow to pass the path via papermill, e.g.,flux start papermill notebooks/4-2-quantum-espresso.ipynb notebooks/4-2-quantum-espresso-out.ipynb -k python3 -p pseudo_dir "${GITHUB_WORKSPACE}/tests/integration".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/pipeline.yml around lines 201 - 202, The notebook hardcodes pseudo_dir and the workflow invokes papermill without passing it, causing CI coupling; add a parameters cell in notebooks/4-2-quantum-espresso.ipynb (and notebooks/4-1-gpaw.ipynb if applicable) that defines pseudo_dir = None as the default parameter, then update the workflow flux start papermill commands to pass the workspace path via papermill -p pseudo_dir "${GITHUB_WORKSPACE}/tests/integration" (e.g., modify the flux start papermill invocation for notebooks/4-2-quantum-espresso.ipynb to include -p pseudo_dir "${GITHUB_WORKSPACE}/tests/integration") so the notebook reads the injected path instead of the hardcoded "/home/runner/..." value.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/pipeline.yml:
- Around line 201-202: The notebook hardcodes pseudo_dir and the workflow
invokes papermill without passing it, causing CI coupling; add a parameters cell
in notebooks/4-2-quantum-espresso.ipynb (and notebooks/4-1-gpaw.ipynb if
applicable) that defines pseudo_dir = None as the default parameter, then update
the workflow flux start papermill commands to pass the workspace path via
papermill -p pseudo_dir "${GITHUB_WORKSPACE}/tests/integration" (e.g., modify
the flux start papermill invocation for notebooks/4-2-quantum-espresso.ipynb to
include -p pseudo_dir "${GITHUB_WORKSPACE}/tests/integration") so the notebook
reads the injected path instead of the hardcoded "/home/runner/..." value.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 397d1763-448c-484a-aa78-80c043143254
📒 Files selected for processing (6)
.github/workflows/pipeline.ymlREADME.mddocs/_toc.ymlnotebooks/4-1-gpaw.ipynbnotebooks/4-2-quantum-espresso.ipynbnotebooks/5-developer.ipynb
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 39 39
Lines 2089 2089
=======================================
Hits 1967 1967
Misses 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Documentation
Chores