Inject std.getitem on parsing ast.Subscript#292
Merged
Conversation
I.e. to parse things like `new_symbol = old_symbol[other_symbol]["constant"]`. Rides a lot of the same infrastructure has attribute access, so this was pulled up to a generic "chain" parser, and arbitrary attribute/item access chains work by injecting their respective stdlib nodes.
Required a bit of an extra guard on the while-node to protect against looped keys:
def wf(d: dict, seed: int):
x = std.identity(seed)
while library.my_condition(x, d[x]):
x = library.loop_inc(x)
return x
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## parser-qol #292 +/- ##
===========================================
Coverage 99.97% 99.97%
===========================================
Files 41 43 +2
Lines 3433 3502 +69
===========================================
+ Hits 3432 3501 +69
Misses 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I.e. to parse things like
new_symbol = old_symbol[other_symbol]["constant"]. Rides a lot of the same infrastructure has attribute access, so this was pulled up to a generic "chain" parser, and arbitrary attribute/item access chains work by injecting their respective stdlib nodes.Required a bit of an extra guard on the while-node to protect against looped keys: