feat(web): adopt upstream pull request surfaces - #14
Merged
Conversation
…isting, update branch, reactions, in-place editing, smarter diffs (#6039) Co-authored-by: Julius Marminge <julius0216@outlook.com> (cherry picked from commit b28f9bf0a1bd562623c027c5ed80b5ca50395b28)
Co-authored-by: Julius Marminge <julius0216@outlook.com> (cherry picked from commit 92d4a2e996b19239d95e32a3feb05208e0a52306)
Rebrand the pull request server-capability copy, drop the redundant footer route subscription the sidebar already derives from its own pathname, and turn four repeatedly-scanned label and status arrays into sets.
Thread transfer impact
This comment will update automatically after the next completed run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts upstream's pull request surfaces work (#6039) and the follow-up that scopes its errors per environment (#6490).
Supersedes #13, which GitHub auto-closed when its base branch
upstream/2026-08-13-batchwas deleted on merge of #12. Same three commits, rebased onto the mergedpylon.What's here
#6039 is upstream's flagship pull request work for this period. It builds on the PR surfaces Pylon already inherited:
#6490 then scopes pull request errors to the environment that produced them, which only makes sense once the list spans several.
Pylon adaptations
One commit at the end:
SidebarChrome.tsx, where Pylon gated the pull requests link on the primary environment's capability and upstream widens it to any connected one. Resolved toward upstream, since all-server listing is the feature.useLocationsubscription to derive which footer page is open. Pylon's footer already derives exactly that from its ownpathname/onFooterPage, and upstream only uses the value as a boolean, so I dropped the duplicate rather than run two router subscriptions in the sidebar footer.Update your T3 Code servers to browse pull requests.to say Pylon, plus the command palette test fixtures.labelsin three filter paths,statusesin the checks reducer). These are scanned once per filter per row, so the list pays for them.Two
react(no-array-index-key)warnings remain inPullRequestChecksPopover.tsxandPullRequestSummaryTab.tsx. Both are deliberate upstream choices with comments explaining them: the host decides how many check runs share a name, so position disambiguates and the index is a suffix on a name-and-url key rather than the key itself. I left that reasoning intact instead of papering over it.Verification
vp test runover all 30 touched test files: 887 passed.@t3tools/web,t3,@t3tools/contracts,@t3tools/client-runtime: no errors.vp checkrepo-wide: clean apart from the two documented warnings above. Baseline for these files before #6039 was clean, so those two are the only lint delta.Verified in a real client against a seeded copy of real data, driving the actual GitHub provider:
&review=approvedinto the URLpingdotgg/t3codepull request showed update branch ("This branch is out-of-date with main by 1 commit"), reactions, and timeline orderingEdit title/Edit descriptionappear on the viewer's own authored pull request and are absent on someone else'sselectedEnvironmentIdin the detail URLModel: Claude Opus 5. Harness: Claude Code.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.