fix(web): keybinding rows, nested markdown images, composer spacing, project picker - #183
Merged
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
(cherry picked from commit 074bcd6dc897f9c28b1bbc04737daa6ee3d8e40f)
(cherry picked from commit c0e09f323ac9f6bf4b9119cbad841db3379588d6)
(cherry picked from commit be218ac768d809087bfcea4d8f15c431f0d70e16)
Adapted for Pylon: the segment cap lands on Pylon's fork-only TaskProgressSegments in chat/TaskProgressStatus.tsx (as MAX_TASK_PROGRESS_SEGMENTS) rather than upstream's TaskSegments helper in ComposerTasksBadge.tsx, which Pylon does not have. Pylon's dismissal helpers in ComposerTasksBadge.tsx are kept, and the ChatView import block drops upstream's shouldShowPlanFollowUpPrompt, which Pylon retired. (cherry picked from commit 660cddd3bc9801e089afcabba11c62f41aeac5c3)
rynfar
force-pushed
the
upstream/2026-08-29-web-polish
branch
from
August 30, 2026 19:03
6c36a25 to
f19e3d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four change sets from the
f94a0d646..1f8ed54adT3 upstream review. Three cherry-picks and one cherry-pick with adaptation.#8627(074bcd6dc) — the sidebar project picker popup stays inside the sidebar (min-w-0 overflow-hiddenon the combobox popup and picker shell). Byte-identical to upstream; follow-up to#5931, already adopted.#8501(c0e09f323) — markdown file previews resolve relative images from the file's directory instead of the project root; Windows drive paths, SVG fragments on signed URLs, and authored width/height/alignment are preserved; copy yields the authored markdown. Byte-identical; Pylon'sworkspaceRelativePathand editor-label divergence inmarkdown-links.ts/ChatMarkdown.tsxare untouched.#8532(be218ac76) — the keybindings settings page becomesSettingsRowitems instead of the four-column table that forced a 680px horizontal scroll. Upstream's file taken verbatim except the two product strings, which say Pylon.#8090(660cddd3b) — four composer spacing defects, all verified present in Pylon: the scroll-to-end pill now ignores the shoulder-tab reserve unless a tab is present; the draft hero reduces its bottom padding when a tab is present; shoulder tabs inset to match the composer corner; and task segment bars hide past 10 steps.The one adaptation
Upstream caps segment bars in its
TaskSegmentshelper. Pylon renders segments through its fork-onlyTaskProgressSegments(TaskProgressStatus.tsx), so the cap (MAX_TASK_PROGRESS_SEGMENTS) lives there instead, with a test pinning both edges. That component is shared with the timeline turn-plan row, so the cap applies there too — at 24 steps the unfitted strip is ~286px of unshrinkable bar crowding out the row label, and thecompleted/totalcount still renders in both places, so no step count goes unrepresented. Review weighed gating onfitand preferred the single behaviour.Pylon's task-dismissal helpers in
ComposerTasksBadge.tsxsurvive; upstream'sshouldShowPlanFollowUpPromptcontext line was dropped from the import hunk because Pylon retired that symbol.Verification
vp test runacross the twelve affected files — 380 tests passed.@t3tools/weband@t3tools/client-runtimetypecheck clean; lint and format clean.#8627/#8501stat-identical to upstream;#8532differs from upstream by exactly the two branding lines; theuseLayoutEffectlands inChatViewContentscope with complete deps;data-chat-composer-main-surfaceconfirmed present so the shoulder reserve measurement is live.Claude Fable 5 in Pylon.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.