feat(pull-requests): link GitHub references, add list filters, defer line stats - #248
Merged
Conversation
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: Theo Browne <me@t3.gg>
#8812 routes link content through a linkChildren element that already wraps children in MarkdownLinkContext. Passing that inside MarkdownExternalLinkContent puts an element where it looks for the leading text it splits with <wbr/>, so a long label became one unbreakable run and overflowed the chat column. Pylon wraps the result instead of the children for exactly this reason. Caught by ChatMarkdown.test.tsx.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three upstream commits for the pull-request surface.
#8812link GitHub references in markdown —#123,owner/repo#123, andcommit SHAs become links
#8809add pull request list filters#6471defer pull request line stats until visible#6471is the notable one:_chat.pull-requests.tsxloses 181 lines andpullRequestList.logic.tsloses 73, because additions/deletions are now fetchedper-row on visibility instead of eagerly for the whole list.
Carve-out
#8812introduces alinkChildrenelement that already wraps children inMarkdownLinkContext, and passes it intoMarkdownExternalLinkContent. Pylondeliberately wraps the result rather than the children, with a comment saying
why:
MarkdownExternalLinkContentinspects its first child for the leading textit splits with
<wbr/>, and an element in that position makes the whole label oneunbreakable run that overflows the chat column.
Adopting upstream's shape verbatim reintroduced exactly that — a long external
link label stopped wrapping.
ChatMarkdown.test.tsx's "keeps external link labelsbreakable when they mix text and formatting" caught it. The autolink condition
(
!isPullRequestAutolink) is adopted; the wrapping order stays Pylon's.Verification
@t3tools/webtypecheck clean, lint clean, 375 pull-request and markdown tests,3388 web tests passing.
One pre-existing failure is unrelated and reproduces on
pylonwith this branchstashed:
src/terminal/ghostty/runtimeAbi.test.tsfails to parse a.wasm?inlineimport locally.Model: Claude Opus 5 in Claude Code.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.