fix(mobile): keep thread scroll bounds current after animations - #249
Merged
Conversation
Co-authored-by: Julius Marminge <julius@mac.lan>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts
#9013. Size-only content changes did not emit a scroll event, so thelist's "is at end" signal went stale after an animation settled — the thread
could think it was pinned to the bottom when it was not, and vice versa. Upstream
adds a
getIsAtEndthat derives the edge from current content size rather thanwaiting for a scroll event.
Carve-out
#9013rewritespatches/@legendapp__list@3.3.5.patch, which carries Pylon's ownone-line fix:
state.pendingMaintainScrollAtEnd = shouldMaintainScrollAtEndinstead of
= false, so the flag is deferred rather than discarded. Verified itsurvives at both the CJS and ESM sites in the rewritten patch (lines 357 and 904),
since a patch-file merge is the one place a lost line produces neither a type
error nor a failing test.
The lockfile conflicted on the patch content hash and was regenerated rather than
hand-merged.
Verification
@t3tools/mobiletypecheck clean, lint clean, 175 thread tests passing.node scripts/release-smoke.tspasses, which is the check that actually exercisesthe patch pin.
Model: Claude Opus 5 in Claude Code.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.