fix(ssh): preserve managed server ownership and install failures - #276
Merged
Conversation
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
(cherry picked from commit f33fdc992488e36ccb70cbb71d55e630b5184cbd)
…088) (cherry picked from commit 39802c06117fae0b3da43624b0d54309c5437c72)
rynfar
force-pushed
the
upstream/2026-09-05-ssh-runner
branch
from
September 6, 2026 02:33
6d866a6 to
b20c9d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH-managed servers launched through npm wrappers can have the wrong recorded PID, breaking graceful shutdown and leaving ports occupied. Exec the resolved CLI directly after installation, and preserve npm installation failures instead of misreporting them as missing build tools or running a path printed by a failed command.
Adopts upstream #9843 and #10088 as one runner-fix series. Pylon package selection, runtime home, and identity stay intact; the partial adoption is recorded in the ledger.
Validation: 33 runner/tunnel tests, SSH package typecheck, targeted lint and formatting pass. Real fixture processes verify PID ownership, graceful shutdown, port reuse, argument quoting, and npm/npx diagnostics. Unix process fixtures are skipped on Windows. No live environment was touched.
The durable implementation and review record is consolidated in companion #279.
Model: GPT-6 Astra. Harness: Codex.