fix(server): keep Windows Prime daemon fallback fail-closed - #29
Merged
Conversation
Thread transfer impact
This comment will update automatically after the next completed run. |
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Windows native daemon mode is intentionally disabled because Prime Agent 0.7.2 cannot authenticate named-pipe peers. The manager nevertheless imported the executable-adjacent Prime package before applying that platform guard, so npm shim/package-layout failures could accidentally determine the fallback instead of the security policy.
Solution
Apply the Windows transport-security guard immediately after deriving the private pipe identity, before loading any Prime package code or attempting process startup. The focused regression omits the fake bridge and uses the nonexistent fixture executable, proving the fail-closed outcome does not depend on package discovery and still spawns nothing.
Verification
vp test run src/provider/prime/PrimeAgentDaemonManager.test.ts src/provider/prime/PrimeAgentBackendSelection.test.ts src/provider/Drivers/PrimeAgentDriver.test.ts— 23 passedgit diff --checkImplemented by OpenAI Codex GPT-5.6 Sol using the Prime Agent harness.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.