Fireproof Rune Fixes

[balugaq]

Closes #155
Closes #156
Closes #157

Can't compile the code for the unknown code. Comment under this PR if issues still exist.

[Seggan]

Ugh it didn't work

[balugaq]

What issues?

[Seggan]

The failing CI

[balugaq]

Uhh, at least as of now, the CI checks for the several PRs I’ve submitted have all failed.

[Seggan]

Yeah I am aware, it's a permissions thing. The dependency submission should really only be running on master anyway. I've tried again.

[Seggan]

There ya go

[LordIdra]

Fireproof rune no longer seems to work..?

[LordIdra]

oh

[LordIdra]

Use ItemStackBuilder.lore to add lore lines instead of

.editData(DataComponentTypes.LORE, lore -> {
                    List<Component> lines = lore.lines();
                    lines.add(TOOLTIP);
                    return ItemLore.lore(lines);
                })

that should fix it

[LordIdra]

I fixed it locally but now there are more errors in console. I'll leave you to have a look

[balugaq]

Fine, just send errors here.

mclo.gs

[LordIdra]

Can you please test locally before PRing? You can do this with the master project, if you need help then let us know. It's much easier for you to test then for me to test and report lots of issues and then you fix them

[balugaq]

I'll test since I set up the master project just now.

[LordIdra]

Nice, thanks for the PR!