Skip to content

Update ruff to write github output and use pyproject.toml#151

Merged
BenediktBurger merged 1 commit into
mainfrom
improve-linting
May 25, 2026
Merged

Update ruff to write github output and use pyproject.toml#151
BenediktBurger merged 1 commit into
mainfrom
improve-linting

Conversation

@BenediktBurger

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented May 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 06387738-9e7e-4aed-813b-3a0dbed4f58c

📥 Commits

Reviewing files that changed from the base of the PR and between 921320d and f387975.

📒 Files selected for processing (1)
  • .github/workflows/pyleco_CI.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated continuous integration linting process configuration to improve output formatting.

Walkthrough

The PyLECO CI workflow "Lint with ruff" step is updated to run ruff check --output-format github instead of the previous explicit error rule selection with full-format output. The remaining workflow steps remain unchanged.

Changes

CI Ruff Linting Configuration

Layer / File(s) Summary
Ruff linting output format update
.github/workflows/pyleco_CI.yml
The "Lint with ruff" step simplifies the ruff invocation by removing --extend-select=E9,F63,F7,F82 and switching from --output-format full to --output-format github for native GitHub workflow annotation output.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A single line hops through the workflow gates,
Ruff's github format now annotates,
No more extended rules to select,
Just cleaner output, what'd you expect?
thump thump 🎉

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions updating ruff to use github output and pyproject.toml, but the changeset only shows ruff being updated to use --output-format github without evidence of pyproject.toml integration. Verify the title matches the actual changes: either confirm pyproject.toml was modified or update the title to reflect only the github output format change.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess alignment with the changeset. Add a pull request description explaining the purpose of updating the ruff configuration and any related changes to improve clarity for reviewers.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch improve-linting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented May 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.27%. Comparing base (921320d) to head (f387975).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   91.11%   91.27%   +0.15%     
==========================================
  Files          39       39              
  Lines        3130     3130              
  Branches      323      323              
==========================================
+ Hits         2852     2857       +5     
+ Misses        236      231       -5     
  Partials       42       42              
Flag Coverage Δ
unittests 91.27% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BenediktBurger
BenediktBurger merged commit 57a2076 into main May 25, 2026
56 of 73 checks passed
@BenediktBurger
BenediktBurger deleted the improve-linting branch May 25, 2026 09:02
@coderabbitai coderabbitai Bot mentioned this pull request Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant