Skip to content

Conversation

@alexrudd2
Copy link
Collaborator

@alexrudd2 alexrudd2 commented Apr 10, 2023

No description provided.

@alexrudd2 alexrudd2 changed the title Enable isort rules in ruff Enable isort (I) rules in ruff Apr 10, 2023
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@janiversen
Copy link
Collaborator

Solved merge conflict in ruff.toml

A hard learned trix: when you submit multiple PRs that change the same file (ruff.toml), make sure there are at least 1 unchanged line between the changes, in that case it works automatically.

@janiversen janiversen merged commit 6f7b66e into dev Apr 10, 2023
@janiversen janiversen deleted the isort-ruff branch April 10, 2023 19:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants