Skip to content

Enable isort (I) rules in ruff #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janiversen merged 2 commits into from
Apr 10, 2023
Merged

Enable isort (I) rules in ruff #1485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2a1ca5
Enable isort rules in ruff
alexrudd2 Apr 10, 2023
1d64c23
Merge branch 'dev' into isort-ruff
janiversen Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@ repos:
- id: end-of-file-fixer
- id: check-yaml
- id: check-added-large-files
- repo: https://github.com/pycqa/isort
rev: 5.12.0
hooks:
- id: isort
exclude: ^(doc/_build|venv|.venv|.git|pymodbus/client/serial_asyncio)
# run ruff with --fix before black
- repo: https://github.com/charliermarsh/ruff-pre-commit
rev: 'v0.0.261'
Expand Down
8 changes: 6 additions & 2 deletions pymodbus/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,13 @@
ReportSlaveIdRequest,
ReportSlaveIdResponse,
)
from pymodbus.pdu import ExceptionResponse, IllegalFunctionRequest
from pymodbus.pdu import (
ExceptionResponse,
IllegalFunctionRequest,
ModbusRequest,
ModbusResponse,
)
from pymodbus.pdu import ModbusExceptions as ecode
from pymodbus.pdu import ModbusRequest, ModbusResponse
from pymodbus.register_read_message import (
ReadHoldingRegistersRequest,
ReadHoldingRegistersResponse,
Expand Down
7 changes: 7 additions & 0 deletions ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,14 @@ select = [
"SIM300",
"SIM401",
"RUF",
"I",
"U",
]
[pydocstyle]
convention = "pep257"
[isort]
lines-after-imports = 2
known-local-folder = [
"common",
"contrib",
]