[WAVE 2] Fix multiphase rigid contact force plot mapping#1062
[WAVE 2] Fix multiphase rigid contact force plot mapping#1062mickaelbegon wants to merge 1 commit into
Conversation
9ee1323 to
f830a96
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1062 +/- ##
==========================================
+ Coverage 77.26% 77.86% +0.60%
==========================================
Files 196 196
Lines 21506 21503 -3
==========================================
+ Hits 16616 16743 +127
+ Misses 4890 4760 -130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Codex analysisThis PR is part of Wave 2 and is rebased onto current Review isolation: it changes only Validation completed by Codex:
@EveCharbie @pariterre, all local and online checks are green. This PR is ready for review as an independent Wave 2 change. |
Summary
Root cause
The default
BiMapping.to_firstvalues were derived from global contact indices. The rigid-contact function returns a phase-local vector, so a phase containing only the second global contact attempted to read local row 1 instead of row 0. This produced empty or mislabeled plots.Validation
MPLCONFIGDIR=/private/tmp/mplconfig-1057 /Users/mickaelbegon/miniconda3/envs/bioptim/bin/python -m pytest tests/shard5/test_configure_problem.py -qCloses #1057
This change is