[WAVE 1] Test printing OCPs without controls#1069
Conversation
|
Wave 1 preparation update: this PR does not touch plotting code. Its shared Matplotlib failure is addressed by prerequisite #1081; it will remain draft until that prerequisite lands and CI is rerun. |
be0f093 to
fcd3159
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1069 +/- ##
=======================================
Coverage 77.26% 77.26%
=======================================
Files 196 196
Lines 21506 21506
=======================================
Hits 16616 16616
Misses 4890 4890
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pariterre
left a comment
There was a problem hiding this comment.
@pariterre reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on mickaelbegon).
Codex analysisCI follow-up after commit cb58f0b:
No numerical expectation was changed. |
Summary
ocp.print()with no control variablesControlType.NONEfixture to the current dynamics signaturen_phaseargument so the regression stays lightweightContext
The production printing code now skips empty control collections correctly, so the historical crash is no longer reproducible. However, the existing no-control test returned before constructing its OCP and could not protect this behavior. This PR restores a small executable path specifically for the reported issue.
Validation
MPLCONFIGDIR=/private/tmp/bioptim-mpl-637 python -m pytest tests/shard6/test_controltype_none.py::test_print_control_type_none -q(1 passed)git diff --checkCloses #637
This change is