Do not run the deploy step on pull requests - #23
Merged
Conversation
A PR from a fork only ever gets a read-only GITHUB_TOKEN, whatever the permissions: contents: write declaration says, so the push to gh-pages always failed with a 403 and marked the run red. Nothing was published by those runs, and nothing could have been - see the runs on PRs pyoomph#19-pyoomph#22. Gating the deploy step on the event turns the PR check into what is actually useful there: it verifies that gen_page.sh still builds, which would catch e.g. an upstream readthedocs layout change breaking gen_example_gallery.py. Publishing still happens on push to main. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fmhceke9votYhvWyGSBKyG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every PR from a fork so far (#19–#22) has ended with a red X on
Deploy Page. The cause is not the change under review: a fork PR gets a read-onlyGITHUB_TOKENregardless of thepermissions: contents: writedeclaration, so the build succeeds and only the final force-push togh-pagesfails:Nothing was published by those runs and nothing could have been, so the failure carried no information — it just emailed a false alarm on every PR.
This gates the deploy step on the event:
The workflow still runs on PRs, and the
Install and Buildstep still executesgen_page.sh— so the check now verifies the thing worth verifying on a PR, and a red X means the build is genuinely broken (e.g. an upstream readthedocs layout change trippinggen_example_gallery.py, which hard-fails by design). Publishing is unchanged: it happens on the push tomainafter the merge, where the token is writable.CLAUDE.mddocumented the old behaviour and is updated to match.Note: this PR's own check should be green — it is the first one that can be.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Fmhceke9votYhvWyGSBKyG