Fix Windows Gitlab test running#2870
Merged
Merged
Conversation
Contributor
|
The python launcher for Windows, |
- Windows: remove stale servercore:1809 image and choco install (runners are now Windows 2022 VMs with Python 3.13 pre-installed) - macOS: update deprecated macos-14-xcode-15 to macos-15-xcode-16 - Linux: bump Python image from 3.12 to 3.13 - All jobs: also run on gitlab* branches with CIBW_ENABLE=all Generated with the help of AI (Amp/Claude Opus 4.7) Amp-Thread-ID: https://ampcode.com/threads/T-019e6496-f89a-74e7-9f6b-655574290e68 Co-authored-by: Amp <amp@ampcode.com>
GraalPy is JVM-based and slow to start; on the small (2-core) GitLab SaaS Windows runners, virtualenv's interpreter query for graalpy.exe times out, failing test_0_basic::test[pip]. Restrict the Windows job's CIBW_ENABLE to all groups except graalpy (other platforms keep "all"). CIBW_ENABLE rather than CIBW_SKIP is used so the test's expected-wheel set (derived from CIBW_ENABLE) stays consistent with what is built. Assisted-by: ClaudeCode:claude-opus-4.8 Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Contributor
Author
|
Thanks for finishing this off, henryiii! I had the same suspicion about the startup time as you, but I never managed to verify it. Did you manage to prove that's the problem? Either way, it's probably a bit of an edge case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These have been failing on main for a little while.
Don't look like a big issue.
pyis trying to execute the shebang in run_tests.py, which is a posix thing. Trying to usepythondirectly...