Skip to content

Conversation

@mammothb
Copy link

While there has been a prior PR trying to update the README examples to pin to a tagged version following the recommendations given. I believe that with the way it's written, it's still pointing to a branch instead of an actual tagged version.

I have updated the examples to pin to an actual tagged version v1.4.2 so that the examples can be used as is without things breaking and still following the recommendations

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for thinking about this but unfortunately this does not fully align with the maintenance considerations I currently have. Sadly, I'll have to reject your PR. Sorry :(

I've specifically used a release-named branch because I didn't want a traveling tag @v1 as GitHub show-cases everywhere. But this branch is stable and follows SemVer so there will be no intentional breaking changes (which may be untrue for the default repo branch). I prefer not to have to maintain updating those pins in the readme because I think that the warning notes are enough and people copying the snippet from the marketplace page would get the corresponding tag baked-in by default.

@webknjaz webknjaz closed this Nov 26, 2021
@webknjaz webknjaz added enhancement New feature or request question Further information is requested wontfix This will not be worked on labels Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request question Further information is requested wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants