Conversation
Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Contributor
Author
|
In particular, I made some minimal changes to the wording and the intensity of the admonition to address @pfmoore comments here: #672 (comment) |
webknjaz
reviewed
Dec 7, 2021
Member
|
@astrojuanlu do you think we need to link https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html ? cc @pganssle |
Contributor
Author
|
AFAIU, that blog post is about the deprecation of direct |
Member
|
Ah, okay, fair enough. |
bhrutledge
reviewed
Dec 9, 2021
Contributor
Author
|
Comments addressed 👍 |
Member
|
Thanks! |
astrojuanlu
deleted the
issue-667-note-problem-with-old-distutils-core-examples-redux
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #667. Continuation of #672, closes #672.
I tried to respect the original spirit of #672, even if that meant not updating the rest of the page (i.e. noting the deprecation of direct
setup.pyinvokations and encouragement forpyproject.tomlfor static metadata), as this would require a bit more work. I prefer to defer that to a future PR.