Closes #667: advise against using distutils directly#672
Closed
Closes #667: advise against using distutils directly#672
Conversation
Member
Author
|
Arising from both the discussion in #667 (and the linked psutil issue), as well as pypa/packaging-problems#288 (where |
pfmoore
requested changes
Nov 10, 2019
| ``setuptools``. This is a `legacy approach`_ that installers [1]_ support | ||
| for backwards compatibility purposes, but using the legacy ``distutils`` API | ||
| directly in new projects is strongly discouraged, as it means that newer | ||
| build commands, like ``setup.py bdist_wheel``, won't work. |
Member
There was a problem hiding this comment.
I'd like to see this worded a little more strongly, to address 2 points:
- The "backward compatibility" support is limited, and may not be compatible with newer installer features (like build isolation). It also won't be maintained indefinitely, which leads to....
- Existing projects are strongly advised to move away from using the legacy
distutilsAPI to ensure that they will continue working as installers evolve.
di
approved these changes
Nov 11, 2019
Member
|
Hey @ncoghlan, could you solve the merge conflict here? |
Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Member
|
@ncoghlan also, there's a huge merge conflict that needs to be solved manually (the browser-based UI is not very helpful here). |
Contributor
|
I'd be happy to take over this and bring it to a mergeable state. |
Member
|
@astrojuanlu feel free to send a PR based on this. |
Contributor
|
Done: #1028 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.