Skip to content

binary-extensions: add cibuildwheel and multibuild#910

Merged
pradyunsg merged 3 commits intopypa:mainfrom
henryiii:patch-4
Jun 29, 2021
Merged

binary-extensions: add cibuildwheel and multibuild#910
pradyunsg merged 3 commits intopypa:mainfrom
henryiii:patch-4

Conversation

@henryiii
Copy link
Copy Markdown
Contributor

@henryiii henryiii commented Jun 1, 2021

This adds a mention of pypa's cibuildwheel and multibuild here before going into the (highly outdated, currently) specifics of building wheels. For most users, this likely is the correct place to go, rather than trying to set things up themselves. For those who might want to do things themselves, the following sections still need updating.

Copy link
Copy Markdown
Contributor

@bhrutledge bhrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting to improve this doc. I have no direct experience with binary extensions, so it's a good read for me. There's one spelling fix, plus some suggestions for clarity.

Comment thread source/guides/packaging-binary-extensions.rst Outdated
Comment thread source/guides/packaging-binary-extensions.rst Outdated
Comment thread source/guides/packaging-binary-extensions.rst Outdated
@henryiii
Copy link
Copy Markdown
Contributor Author

Thanks, @bhrutledge!

@henryiii
Copy link
Copy Markdown
Contributor Author

There's no multibuild project summary, so this PR is failing after the change. I think the best fix would be to add a multibuild section under non PyPA project, rather than to revert to a link. Will make a PR for that that this PR will then depend on.

@henryiii henryiii marked this pull request as draft June 28, 2021 15:02
@henryiii henryiii mentioned this pull request Jun 28, 2021
henryiii and others added 2 commits June 29, 2021 15:34
Copy link
Copy Markdown
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although this whole guide likely needs to be updated and completed. :)

Comment thread source/guides/packaging-binary-extensions.rst Outdated
Comment thread source/guides/packaging-binary-extensions.rst Outdated
@henryiii
Copy link
Copy Markdown
Contributor Author

I'm working on it, in small pieces. I'll tag a few possibly interested parties when I make the next PRs (likely after PyHEP and SciPy, so in a couple of weeks at the earliest)

@henryiii henryiii marked this pull request as ready for review June 29, 2021 19:42
@pradyunsg pradyunsg merged commit 4c3440d into pypa:main Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants