Skip to content

chore: add multibuild#933

Merged
pradyunsg merged 3 commits intopypa:mainfrom
henryiii:henryiii/chore/multibuild
Jun 29, 2021
Merged

chore: add multibuild#933
pradyunsg merged 3 commits intopypa:mainfrom
henryiii:henryiii/chore/multibuild

Conversation

@henryiii
Copy link
Copy Markdown
Contributor

This adds multibuild, pre-req for #910. CC @matthew-brett - better description welcome (we don't have much of a description on cibuildwheel either, @pypa/cibuildwheel-team).

@henryiii henryiii force-pushed the henryiii/chore/multibuild branch from 8d05bcd to 9e44aa4 Compare June 28, 2021 15:21
Copy link
Copy Markdown
Contributor

@bhrutledge bhrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be pedantic, but "wheel" seems worth defining.

Comment thread source/key_projects.rst Outdated
Comment thread source/key_projects.rst Outdated
@bhrutledge
Copy link
Copy Markdown
Contributor

Also, FWIW, I think it would have been okay to add this to #910.

Co-authored-by: Brian Rutledge <brian@bhrutledge.com>
@henryiii
Copy link
Copy Markdown
Contributor Author

Also, FWIW, I think it would have been okay to add this to #910.

I've been told before by @webknjaz it's better to keep things separate, so I've tried to do that. If one part blocks, the other can still go in.

Comment thread source/key_projects.rst Outdated
Copy link
Copy Markdown
Contributor

@bhrutledge bhrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to keep things separate,

Agreed. In this case, though, it seems like these changes are tightly-coupled to the changes in #910, and IMHO would be more easily reviewed together. I don't think that would fall under @webknjaz's qualifications for breaking it up:

I find it easier to review/approve separate unrelated changes so if one of the updates wouldn't block others from being merged. Usually when the title contains references to many things, has "and" in it, or is too vague within the 50 char limit, it's a sign that the PR is too broad and when you can describe its separate parts with a few specific titles, it's a good idea to have a PR per such a title.

But I'm just being nit-picky while learning the ropes as a gardener for this project. 😄

@pradyunsg
Copy link
Copy Markdown
Member

I've been told before by @webknjaz it's better to keep things separate, so I've tried to do that.

IMO, this is a balancing act. It's possible to go too-far with breaking up PRs -- having a bias toward smaller is good (easier to review + iterate), as long as there's no dependency between the various PRs. If there's dependencies in the changes, it's much better to just combine the changes into a single PR that can be reviewed as a whole.

Copy link
Copy Markdown
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henryiii for the PR and @bhrutledge for the thoughtful reviews! ^>^

@pradyunsg pradyunsg merged commit fdb7d85 into pypa:main Jun 29, 2021
@henryiii henryiii deleted the henryiii/chore/multibuild branch June 29, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants